Remove code for Cap'n Proto versions before 0.9 - #331
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste |
hebasto
changed the title
The removed code has been dead since db4f9a3, which bumped the minimum required Cap'n Proto version to 0.9.
9b2e9f8 to
788f17a
Compare
|
lgtm ACK 788f17a |
| "0.7.0" = "sha256-Y/7dUOQPDHjniuKNRw3j8dG1NI9f/aRWpf8V0WzV9k8="; | ||
| "0.7.1" = "sha256-3cBpVmpvCXyqPUXDp12vCFCk32ZXWpkdOliNH37UwWE="; | ||
| "0.8.0" = "sha256-rfiqN83begjJ9eYjtr21/tk1GJBjmeVfa3C3dZBJ93w="; | ||
| "0.8.1" = "sha256-OZqNVYdyszro5rIe+w6YN00g6y8U/1b8dKYc214q/2o="; |
There was a problem hiding this comment.
In commit "Remove code for Cap'n Proto versions before 0.9" (788f17a)
Other changes in this commit all make sense, but I do think it'd be a little nicer to keep these hashes as they are convenient for testing. The dependency on 0.9.0 is weak and only due to a getFd call which I think we may want to drop anyway, because capnproto has long had better mechanisms for communicating across threads than writing to file descriptors: #274 (comment)
4 participants
The removed code has been dead since db4f9a3, which bumped the minimum required Cap'n Proto version to 0.9.